chore(bigquery): remove dev gate flag and beta api for tracing telemetry#12624
Open
chore(bigquery): remove dev gate flag and beta api for tracing telemetry#12624
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the temporary development gate for HTTP tracing in the BigQuery RPC implementation by deleting the isHttpTracingEnabled() method and its associated system property. As a result, HTTP tracing attributes are now consistently applied whenever OpenTelemetry tracing is enabled. The test suite has been updated to remove system property manipulations and the specific test scenarios for the disabled gate. I have no feedback to provide.
ldetmer
added
the
do not merge
ldetmer
changed the title
blakeli0
reviewed
Apr 8, 2026
| */ | ||
| @BetaApi | ||
| @VisibleForTesting | ||
| public class ErrorTypeUtil { |
Contributor
There was a problem hiding this comment.
Can we make this package private? I think we plan to remove it and use the gax one later. However, removing a non-beta public class would be a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dev gate flag and BetaApi tags from big query open telemetry tracing, as we are feature complete.
Note by removing dev gate we will have added additional telemetry may contain sensitive data such as resource names, full URLs, and error messages.
Fixes #12100