Add Script to Update BoringSSL#204
Merged
Merged
Conversation
jonasfj
reviewed
Jun 29, 2025
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
I haven't tested this, but it looks reasonable to me.
HamdaanAliQuatil
force-pushed
the
update-boringssl
branch
from
e7d3223 to
2fabe63
Compare
jonasfj
approved these changes
Dec 18, 2025
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
Let's remove the python script, we shouldn't need that right?
Comment on lines
+18
to
+19
| contents: write | ||
| pull-requests: write |
Member
There was a problem hiding this comment.
I'm not sure we can do this, but let's try 🤣
Here is the current settings as far as I can set them:
jonasfj
previously requested changes
Jan 26, 2026
HamdaanAliQuatil
dismissed
jonasfj’s stale review
dismissal of stale review. re-requesting review
jonasfj
reviewed
May 4, 2026
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
I don't strictly oppose this approach, but I think we should explore what it would take to use the gen/sources.cmake file that is pregenerated and maintained in the boringssl repository.
Member
|
So this doesn't work, it doesn't copy the sources in correctly. |
jonasfj
reviewed
May 13, 2026
jonasfj
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.