Skip to content

🧪 [testing improvement] Add test for case-insensitive hostname matching#622

Merged
rowan-m merged 1 commit intomainfrom
testing-improvement-hostname-case-insensitive-5612976521281188627
Apr 4, 2026
Merged

🧪 [testing improvement] Add test for case-insensitive hostname matching#622
rowan-m merged 1 commit intomainfrom
testing-improvement-hostname-case-insensitive-5612976521281188627

Conversation

@rowan-m
Copy link
Copy Markdown
Contributor

@rowan-m rowan-m commented Apr 4, 2026

🎯 What: The testing gap addressed was the lack of a test case for case-insensitive hostname verification in the ReCaptcha class.
📊 Coverage: The new test testVerifyHostnameMatchCaseInsensitive covers scenarios where the expected hostname and the response hostname have different casing (e.g., 'HOST.NAME' vs 'host.name' and vice versa).
Result: This improvement ensures that the case-insensitive matching behavior is preserved during future refactoring and increases the reliability of the hostname validation logic.


PR created automatically by Jules for task 5612976521281188627 started by @rowan-m

- Added testVerifyHostnameMatchCaseInsensitive to ReCaptchaTest.php.
- Verified that the test correctly handles mismatched casing between expected and actual hostnames.
- Confirmed that the test fails if case-insensitive matching is disabled.

Co-authored-by: rowan-m <108052+rowan-m@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 100.0%. remained the same
when pulling a7a276e on testing-improvement-hostname-case-insensitive-5612976521281188627
into a6c5041 on main.

@rowan-m rowan-m merged commit e235107 into main Apr 4, 2026
7 checks passed
@rowan-m rowan-m deleted the testing-improvement-hostname-case-insensitive-5612976521281188627 branch April 4, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants