Skip to content

fix: Accept HTTP/1.1 responses in SocketPost to support proxies #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rowan-m merged 3 commits into from
Mar 26, 2026
Merged

fix: Accept HTTP/1.1 responses in SocketPost to support proxies #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c14ed57
fix: accept HTTP/1.1 responses in SocketPost to support proxies
SNO7E-G Mar 26, 2026
9b1acb9
test: verify SocketPost correctly rejects HTTP/1.1 errors
SNO7E-G Mar 26, 2026
df61d9d
test: verify SocketPost correctly rejects unsupported HTTP protocols
SNO7E-G Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ReCaptcha/RequestMethod/SocketPost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function submit(RequestParameters $params): string
$response = '';
}

if (0 !== strpos($response, 'HTTP/1.0 200 OK')) {
if (1 !== preg_match('#^HTTP/1\.[01] 200 OK#', $response)) {
return '{"success": false, "error-codes": ["'.ReCaptcha::E_BAD_RESPONSE.'"]}';
}

Expand Down
45 changes: 45 additions & 0 deletions tests/ReCaptcha/RequestMethod/SocketPostTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,22 @@ public function testOverrideSiteVerifyUrl(): void
$this->assertTrue(SocketPostGlobalState::$fcloseCalled);
}

public function testSubmitReturnsResponseWhenHttp11(): void
{
SocketPostGlobalState::$fgetsResponses = [
"HTTP/1.1 200 OK\r\n",
"Content-Type: application/json\r\n",
"\r\n",
'RESPONSEBODY',
];

$sp = new SocketPost();
$response = $sp->submit(new RequestParameters('secret', 'response'));

$this->assertEquals('RESPONSEBODY', $response);
$this->assertTrue(SocketPostGlobalState::$fcloseCalled);
}

public function testStreamTimeoutFailureReturnsError(): void
{
SocketPostGlobalState::$streamSetTimeoutSuccess = false;
Expand Down Expand Up @@ -272,4 +288,33 @@ public function testStreamGetContentsReturnsFalse(): void

$this->assertEquals('{"success": false, "error-codes": ["'.ReCaptcha::E_BAD_RESPONSE.'"]}', $response);
}

public function testBadResponseReturnsErrorWhenHttp11(): void
{
SocketPostGlobalState::$fgetsResponses = [
"HTTP/1.1 500 Internal Server Error\r\n",
"\r\n",
'FAIL',
];

$sp = new SocketPost();
$response = $sp->submit(new RequestParameters('secret', 'response'));

$this->assertEquals('{"success": false, "error-codes": ["'.ReCaptcha::E_BAD_RESPONSE.'"]}', $response);
}

public function testBadResponseReturnsErrorWhenHttp2(): void
{
SocketPostGlobalState::$fgetsResponses = [
"HTTP/2.0 200 OK\r\n",
"Content-Type: application/json\r\n",
"\r\n",
'RESPONSEBODY',
];

$sp = new SocketPost();
$response = $sp->submit(new RequestParameters('secret', 'response'));

$this->assertEquals('{"success": false, "error-codes": ["'.ReCaptcha::E_BAD_RESPONSE.'"]}', $response);
}
}
Loading