Fix visualization HTML charset handling#466
Open
Samay10 wants to merge 1 commit into
Open
Conversation
|
Your branch is 1 commits behind git fetch origin main
git merge origin/main
git pushNote: Enable "Allow edits by maintainers" to allow automatic updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234
Description
Saved visualization HTML should always be interpreted as UTF-8. Without an explicit charset, some browsers can guess a different encoding based on the user’s system settings that might cause non-ASCII text to render incorrectly.
This change adds a UTF-8 charset meta tag to the HTML returned by
visualize(), so saved visualization files render consistently across browsers.How Has This Been Tested?
pyink langextract/visualization.py tests/visualization_test.py --config pyproject.tomlpytest tests/visualization_test.py(5 passed)pytest tests; the visualization tests passed, but the full suite still has unrelated local failures from the missing optionalopenaipackage and one pip-install plugin discovery testChecklist