Record class reference dependencies for incremental compilation#3013
Draft
jaschdoc wants to merge 2 commits into
Draft
Record class reference dependencies for incremental compilation#3013jaschdoc wants to merge 2 commits into
jaschdoc wants to merge 2 commits into
Conversation
This test shows the presence of the bug where KSP does not capture transitive dependencies of class references, e.g., `MyClass::class`.
jaschdoc
force-pushed
the
fix-incremental3011
branch
from
379fdd4 to
cf3b074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing
MyClass::classreferences to the dependency graph. If such references occur in class files then it stores a synthetic file handle for it and restores the symbol representing the type computing dirtiness in a subsequent compilation.Fixes #3011