Add regression test for annotation array value type#3010
Open
Yong-yuan-X wants to merge 3 commits into
Open
Conversation
jaschdoc
reviewed
Jul 2, 2026
jaschdoc
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the PR @Yong-yuan-X! It looks good. Just a few minor comments 👍
Author
|
@jaschdoc Thanks for the review! I addressed both comments:
Verified locally: ./gradlew :kotlin-analysis-api:test \
--tests com.google.devtools.ksp.test.AAConfiguredUnitTestSuite.testAnnotationArrayValueType \
--tests com.google.devtools.ksp.test.PsiConfiguredUnitTestSuite.testAnnotationArrayValueTypeBoth targeted tests passed. |
jaschdoc
reviewed
Jul 3, 2026
jaschdoc
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the quick update. Just one more thing and then it's good to go.
Author
|
Thanks for the follow-up! I added the Kotlin annotation case as requested. The test now uses both Verified locally: ./gradlew :kotlin-analysis-api:test \
--tests com.google.devtools.ksp.test.AAConfiguredUnitTestSuite.testAnnotationArrayValueType \
--tests com.google.devtools.ksp.test.PsiConfiguredUnitTestSuite.testAnnotationArrayValueTypeBoth targeted tests passed. |
jaschdoc
approved these changes
Jul 3, 2026
jaschdoc
left a comment
Collaborator
There was a problem hiding this comment.
Great, thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a failing regression test for Java annotation array arguments.
The test covers a Java source annotation usage where a Java annotation array argument is read through
KSValueArgument.value. It verifies that the value should be exposed asArray<*>, matching the KSP API contract.The test is currently registered with
runFailingTestin both AA and PSI configured suites to document the existing incorrect behavior before implementing the fix.Refs #3008
Verified locally: