Skip to content

python: Make it easy to link to external libjsonnet #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcpunk wants to merge 1 commit into
base: master
Choose a base branch
from
+33 −8
Open

python: Make it easy to link to external libjsonnet #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 33 additions & 8 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,17 @@
"python/_jsonnet.c",
]

# When set to any non-empty value, link dynamically against a pre-built
# libjsonnet.so.0 rather than compiling the C++ sources into the extension.
# This is the mode used when packaging against a system or Spack-provided
# libjsonnet (e.g. in RPM builds). The shared object must be on the linker
# search path at both build and runtime.
#
# Usage:
# JSONNET_DYNAMIC_LINK=1 pip install .
# JSONNET_DYNAMIC_LINK=1 python setup.py build_ext --inplace
_DYNAMIC_LINK = bool(os.environ.get("JSONNET_DYNAMIC_LINK", ""))


def get_version():
"""
Expand Down Expand Up @@ -96,7 +107,12 @@ def build_extensions(self):
super().build_extensions()

def run(self):
self._pack_std_jsonnet()
# std.jsonnet.h is generated from the bundled stdlib and is only
# needed when compiling the C++ sources into the extension. In
# dynamic-link mode the pre-built shared library already contains
# the stdlib, so skip the generation step.
if not _DYNAMIC_LINK:
self._pack_std_jsonnet()
super().run()


Expand All @@ -113,6 +129,19 @@ def run(self):
_PY_LIMITED_API = 0x03080000
_bdist_limited_api_tag = "cp38"

if _DYNAMIC_LINK:
print("setup.py: JSONNET_DYNAMIC_LINK set; linking dynamically against libjsonnet.so.0")
_ext_sources = ["python/_jsonnet.c"]
_ext_extra_include_dirs = []
_ext_extra_objects = ["libjsonnet.so.0"]
else:
_ext_sources = LIB_SOURCES
_ext_extra_include_dirs = [
"third_party/md5",
"third_party/json",
"third_party/rapidyaml",
]
_ext_extra_objects = []

setuptools.setup(
name="jsonnet",
Expand All @@ -130,13 +159,9 @@ def run(self):
else []
),
py_limited_api=(_PY_LIMITED_API is not None),
sources=LIB_SOURCES,
include_dirs=[
"include",
"third_party/md5",
"third_party/json",
"third_party/rapidyaml",
],
sources=_ext_sources,
include_dirs=["include"] + _ext_extra_include_dirs,
extra_objects=_ext_extra_objects,
language="c++",
)
],
Expand Down