feat: Refactor repositories download contents#4153
Open
stevehipwell wants to merge 3 commits intogoogle:masterfrom
Open
feat: Refactor repositories download contents#4153stevehipwell wants to merge 3 commits intogoogle:masterfrom
stevehipwell wants to merge 3 commits intogoogle:masterfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4153 +/- ##
==========================================
+ Coverage 93.76% 93.77% +0.01%
==========================================
Files 211 211
Lines 19701 19677 -24
==========================================
- Hits 18472 18452 -20
+ Misses 1031 1029 -2
+ Partials 198 196 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the behaviour of
DownloadContents&DownloadContentsWithMetawith the former now being a direct passthrough to the latter as the only difference was the signature. The code has been refactored to use the API directly instead of via an unnecessary layer of indirection.I've added an OpenAPI update to this PR as it proves that the updated code works against GitHub.
This change is required for #4151.