Vendor bazel's starlark package#307
Open
keith wants to merge 7 commits into
Open
Conversation
Not sure yet if we need more transitives, we'll see
This is likely easier to keep in sync than reconciling with copybara/third_party/BUILD
Contributor
Author
|
If folks are open to this reviewing commit by commit is easiest |
alexeagle
reviewed
Dec 18, 2024
| bazel_dep(name = "rules_pkg", version = "0.10.1") | ||
| bazel_dep(name = "rules_python", version = "0.31.0") | ||
|
|
||
| non_module_deps = use_extension("//:repositories.bzl", "non_module_deps") |
There was a problem hiding this comment.
perhaps rules_python dependency can be dropped as well? It seems it's only needed by io_bazel and not referenced in this repo
Collaborator
|
I think I did something similar, looking good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the TODO in the MODULE.bazel by coping over the current bazel starlark package. This allows us to remove pulling bazel at build time and having a separate maven repo for it.