Bump Trillian to v1.8.0, go to v1.26.0, and drop tracing support - #1832
Merged
Merged
Conversation
phbnf
changed the title
phbnf
changed the title
phbnf
changed the title
phbnf
marked this pull request as ready for review
September 21, 2026 15:37
AlCutter
approved these changes
Sep 21, 2026
Comment on lines
+209
to
+229
| // String method returns a string representation of the tree head. | ||
| func (th TreeHead) String() string { | ||
| return fmt.Sprintf("[SHA256RootHash: %x, TreeSize: %d]", th.SHA256RootHash, th.TreeSize) | ||
| } | ||
|
|
||
| // String method returns a string representation of the log state. | ||
| func (s *LogState) String() string { | ||
| if s == nil { | ||
| return "<nil>" | ||
| } | ||
| return fmt.Sprintf("Timestamp: %v", s.Timestamp) | ||
| } | ||
|
|
||
| // String method returns a string representation of the read-only log state. | ||
| func (r *ReadOnlyLogState) String() string { | ||
| if r == nil { | ||
| return "<nil>" | ||
| } | ||
| return fmt.Sprintf("%s, FinalTreeHead: %s", &r.LogState, r.FinalTreeHead) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Are these changes meant to be in this PR?
(also, should the methods be located near to the structs they're on?)
Contributor
Author
There was a problem hiding this comment.
Yes they are meant to be here: golangci-lint was complaining because were were using "%q" in logs with structs that didn't have a Stringer interface. I figured it was better to add the "String" methods rather than switching to "%v".
My first hunch was to put the methods next to the struct, until I realized the structs were just above and that there was some benefits to having the full structs defined one after the other one since they are imbricated.
Since we both had the same intuition, I've moved them back closer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
String()methods to a bunch of loglistv3 struct to fixgolangci-lintBonus: It drops dependencies on opencensus, and the deprecated AWS SDK, which should make some security warnings and an issue (#1673) obsolete.
Checklist