antigravity: remove vertex env-var override (superseded by AGY 0.1.7)#331
Merged
Conversation
google-antigravity 0.1.7 reads GOOGLE_GENAI_USE_VERTEXAI /
GOOGLE_GENAI_USE_ENTERPRISE + GOOGLE_CLOUD_{PROJECT,LOCATION} natively,
so the sidecar no longer needs _vertex_kwargs_from_env to thread them
into LocalAgentConfig.
- Delete _vertex_kwargs_from_env + VertexKwargs.
- _build_default_config: bare LocalAgentConfig(system_instructions=...).
- _has_credentials: read project/location from env (SDK hydrates them
onto VertexEndpoint, not LocalAgentConfig).
- Update tests accordingly.
Requires the 0.1.7 bump. Credential resolution is startup-only and
does not touch the save_dir/state_dir resume path.
Ref #325
2 tasks
joycel-github
marked this pull request as draft
July 18, 2026 00:23
joycel-github
marked this pull request as ready for review
July 18, 2026 00:24
wjjclaud
approved these changes
Jul 18, 2026
feifeigood
added a commit
to feifeigood/ax
that referenced
this pull request
Jul 20, 2026
feifeigood
added a commit
to feifeigood/ax
that referenced
this pull request
Jul 20, 2026
merge: sync upstream ax through 5d0e245 (google#329 google#331 google#327)
rakyll
added a commit
that referenced
this pull request
Jul 21, 2026
- Make changes to the testagents for a realistic sub agent demo - Sanitize agent names, replace - with _ to avoid malformation errors - Increase the idle networking timeout across different configs, set a high GKE ingress timeout to enable long running operations - Register AX_TEST_AGENTS with description and name - Make changes to the symptom prompt and disable bash tool improve the selection quality for the demo - Move inflight tracking to server to avoid double suspension - Make the resumption command to honor --server if set Follow up: - Remove AX_TEST_AGENTS once we don't need them. - Work on Gemini planner to support better selection among the agents and the bash tool.
rakyll
pushed a commit
that referenced
this pull request
Jul 21, 2026
google-antigravity 0.1.7's _connect_websocket retries both "localhost" and "127.0.0.1" when dialing localharness (local_connection.py:993), so the sidecar no longer needs to patch /etc/hosts for substrate/gVisor environments where localhost may not resolve. Ref #325 antigravity: guard conversation_id for safe save_dir use (#312) harness_server uses the caller-supplied conversation_id directly as a per-conversation storage directory name (save_dir = state_dir / conversation_id) before the Antigravity harness ever sees it, so a value like "../escape" could traverse outside state_dir. Reject an empty id or one containing a path separator or a "." / ".." component at the boundary in _run_turn, returning an INVALID_ARGUMENT end frame. This is intentionally only a path-safety guard, not the id-format contract. The Antigravity harness owns that: it validates the forwarded cascade_id (length and character set) per cl/948016352. Keeping the format rule in one place avoids the two layers drifting. chore: remove stale docs, gitignore, and Makefile entries (#329) - CONTRIBUTING.md: drop 'make run-remote' (no such Makefile target) - .gitignore: remove orphaned entries (local/remote_agent, sandbox-router, tasklog, axepp, google-cloud-sdk, test-sandbox-config.yaml) - Makefile: add missing deps, clean-logs to .PHONY antigravity: remove vertex env-var override (superseded by AGY 0.1.7) (#331) * antigravity: remove vertex env-var override (superseded by AGY 0.1.7) google-antigravity 0.1.7 reads GOOGLE_GENAI_USE_VERTEXAI / GOOGLE_GENAI_USE_ENTERPRISE + GOOGLE_CLOUD_{PROJECT,LOCATION} natively, so the sidecar no longer needs _vertex_kwargs_from_env to thread them into LocalAgentConfig. - Delete _vertex_kwargs_from_env + VertexKwargs. - _build_default_config: bare LocalAgentConfig(system_instructions=...). - _has_credentials: read project/location from env (SDK hydrates them onto VertexEndpoint, not LocalAgentConfig). - Update tests accordingly. Requires the 0.1.7 bump. Credential resolution is startup-only and does not touch the save_dir/state_dir resume path. Ref #325 * antigravity: drop stale _has_credentials docstring note about vertex env override Interactions: persist interactions harness with durable dir and resume from it (#327) interactions: make WorkDir authoritative for run_command (#335) The interactions harness executed run_command relative to the process's ambient working directory, which is not reliably the agent's workspace: with no Cwd argument the command ran wherever the process cwd happened to be, and a model-supplied Cwd (including "/") was honored blindly. As a result tool calls often ran from "/" instead of the configured workspace (#332). Make the workspace directory authoritative in the executor rather than relying on ambient process state: - Add AntigravityInteractionsConfig.WorkDir (defaults from AX_HARNESS_WORKDIR). - run_command now resolves its directory via resolveRunDir: no Cwd -> WorkDir; relative Cwd -> joined under WorkDir; absolute Cwd -> honored as-is. Empty WorkDir preserves the previous process-cwd behavior. - Add WorkspaceSystemInstruction to orient the agent about its working directory so it emits workspace-relative paths, and wire it in cmd/ax. Fixes #332 Remove the binary (#334) * Remove the binary * chore: add e2e directory to .gitignore * refactor: migrate binary file check to a dedicated workflow file * fix: restrict binary file check to added, copied, or modified files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_vertex_kwargs_from_envsidecar override (andVertexKwargs) now thatgoogle-antigravityreadsGOOGLE_GENAI_USE_VERTEXAI/GOOGLE_GENAI_USE_ENTERPRISE+GOOGLE_CLOUD_{PROJECT,LOCATION}natively.Testing
Part of #325.