Fix the episode_steps property binding - #162
Open
hartikainen wants to merge 1 commit into
Open
hartikainen wants to merge 1 commit into
hartikainen wants to merge 1 commit into
Conversation
Draft
Currently, Reverb passes `py::call_guard` directly to the `episode_steps` property declaration. As explained in [pybind11's upstream change](pybind/pybind11#5533), property declarations silently ignored these guards, and the added compile-time check rejects that usage, preventing the binding from compiling. This PR wraps the `episode_steps` getter in `py::cpp_function` and applies the call guard to that function so that reading the property releases the GIL as intended.
hartikainen
force-pushed
the
kristian/episode-steps-binding
branch
2 times, most recently
from
September 19, 2026 17:22
2617cb3 to
4ee14dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Reverb passes
py::call_guarddirectly to theepisode_stepsproperty declaration. As explained in pybind11's upstream change, property declarations silently ignored these guards, and the added compile-time check rejects that usage, preventing the binding from compiling.This PR wraps the
episode_stepsgetter inpy::cpp_functionand applies the call guard to that function so that reading the property releases the GIL as intended.