Android: fix remote skill URL validation for GitHub URLs#642
Android: fix remote skill URL validation for GitHub URLs#642txhno wants to merge 4 commits intogoogle-ai-edge:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Code reviewFound 1 issue:
The Android-side URL normalization and HTML-detection improvements look correct, but the linked issue will not be resolved for iOS users. Recommendation for maintainers: merge this fix into the Android app source and comment on how it can be ported into the iOS version of the app. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
|
Pushed a follow-up commit on this branch ( |
|
@tg-agent review |
Partial fix for #619 on the Android client.
This improves remote skill import in four ways:
SKILL.mdpathrun_jsskills hosted ongithub.com/raw.githubusercontent.comwith an explicit hosting message instead of a misleading frontmatter parse failureThe issue reporter also mentioned iOS/macOS behavior, but I do not see the corresponding iOS/macOS client source in this repository to patch here. If that client code is available elsewhere, the same normalization / raw-content validation approach can be mirrored there.