Skip to content

Android: fix remote skill URL validation for GitHub URLs#642

Open
txhno wants to merge 4 commits intogoogle-ai-edge:mainfrom
txhno:fix/skill-url-validation-619
Open

Android: fix remote skill URL validation for GitHub URLs#642
txhno wants to merge 4 commits intogoogle-ai-edge:mainfrom
txhno:fix/skill-url-validation-619

Conversation

@txhno
Copy link
Copy Markdown

@txhno txhno commented Apr 9, 2026

Partial fix for #619 on the Android client.

This improves remote skill import in four ways:

  • normalize common GitHub tree/blob/raw URLs into a fetchable SKILL.md path
  • detect HTML responses early and return a clearer validation error
  • reject run_js skills hosted on github.com / raw.githubusercontent.com with an explicit hosting message instead of a misleading frontmatter parse failure
  • document the supported GitHub-hosted URL forms and clarify that this repository currently contains the Android-side implementation of that URL-loading flow

The issue reporter also mentioned iOS/macOS behavior, but I do not see the corresponding iOS/macOS client source in this repository to patch here. If that client code is available elsewhere, the same normalization / raw-content validation approach can be mirrored there.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tg-agent
Copy link
Copy Markdown

tg-agent commented Apr 9, 2026

Code review

Found 1 issue:

  1. The PR fixes issue [Bug]: Can't install custom or example skills - failing with same error message #619, but the issue was filed from an iPhone 15 Pro running iOS — and the reporter explicitly noted the same failure on both iPhone and Mac. All changes in this PR target the Android Kotlin source files; no iOS counterpart has been made available in this repo.

/*
* Copyright 2026 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.

The Android-side URL normalization and HTML-detection improvements look correct, but the linked issue will not be resolved for iOS users.

Recommendation for maintainers: merge this fix into the Android app source and comment on how it can be ported into the iOS version of the app.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@txhno txhno changed the title Fix remote skill URL validation for GitHub URLs Android: fix remote skill URL validation for GitHub URLs Apr 16, 2026
@txhno
Copy link
Copy Markdown
Author

txhno commented Apr 16, 2026

Pushed a follow-up commit on this branch (3c5a61b) that makes the repo docs explicit about scope: the URL-loading behavior documented and implemented here is the Android client path in this repository.

@txhno
Copy link
Copy Markdown
Author

txhno commented Apr 16, 2026

@tg-agent review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants