Open
Conversation
x0152
reviewed
Apr 1, 2026
x0152
reviewed
Apr 1, 2026
Collaborator
|
I think it’s worth checking these files as well:
there are still references to PoW there |
Collaborator
Author
I've cleaned them all. But now I need to build the image and run it on GPU node. I will report the results |
qdanik
reviewed
Apr 3, 2026
| @@ -0,0 +1,200 @@ | |||
| """PoC callback sender with retry-until-stop and bounded buffer.""" | |||
Contributor
There was a problem hiding this comment.
@akup I'd suggest do not combine cleanup + new patches logic and create one more PR for the new feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Clean PoW from MLNode and keep PoC networking patch local
Important
I will run it on GPU node first to check everything works after cleanup
Motivation
PoW logic is no longer used in
mlnode, but the repository still carried PoW-related structure and callback wiring assumptions.At the same time, PoC v2 logic now lives in the forked vLLM codebase, while our networking integration concerns still belong to this repo.
This PR clarifies that boundary and keeps only the pieces we still actively rely on.
Problem this PR solves
mlnodestill contained legacy PoW traces even though PoW is deprecated in this stack.decentralized-apishould remain controlled in this repo, not drift in upstream vLLM internals.What this PR does
mlnodepaths that are no longer used.gonka-ai/vllm(./vllm/poc), but applies local callback patching from this repo.mlnode/packages/poc/patches/callbacks.pyas the local networking-layer override.mlnode/packages/poc/README.md.Security / networking example included
The callback patch includes an example of signing callback payloads with
POC_SIGNATURE_KEY.This can be used by
decentralized-apito verify callback authenticity, which is useful when callback endpoints are publicly exposed due to infrastructure constraints (e.g., mixed providers for ML nodes and API nodes).Expected outcome
mlnodeRelation to other PRs
#537 and #417 patching mlnode. I think this PR can go first to cleanup mlnode before adding functionality