fix(keeper): use regexp instead of fmt.Sscanf to parse ErrInsufficientFunds in ClaimRewards#970
Open
Mayveskii wants to merge 1 commit intogonka-ai:mainfrom
Open
Conversation
…Rewards
parseBalanceError used fmt.Sscanf with hardcoded denomination names
("nicoin", "ngonka"). If the SDK error message format changes or a
different denomination is used, the parse silently fails and logs
spendable=0 required=0 making the balance diagnostics useless.
Replace with a compiled regexp that matches the numeric amounts without
depending on specific denomination names. The pattern matches the stable
part of the Cosmos SDK ErrInsufficientFunds message:
"spendable balance <N><denom> is smaller than <N><denom>"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parseBalanceError uses fmt.Sscanf with hardcoded denom names nicoin/ngonka. If SDK changes error format, parse silently returns 0,0 making balance diagnostics useless.
Fix
Use compiled regexp matching amounts without hardcoded denom names.
Impact: robust parsing regardless of denomination, pre-compiled pattern has zero overhead