Skip to content

Migration of Common_gc tests from Robot to Playwright#22707

Open
adityachopra29 wants to merge 32 commits intogoharbor:mainfrom
adityachopra29:common-gc-migration
Open

Migration of Common_gc tests from Robot to Playwright#22707
adityachopra29 wants to merge 32 commits intogoharbor:mainfrom
adityachopra29:common-gc-migration

Conversation

@adityachopra29
Copy link
Copy Markdown

@adityachopra29 adityachopra29 commented Jan 4, 2026

Comprehensive Summary of your change

Changes Made

  • Created a file common-gc-spec.ts containing all the tests.
  • Since most of the tests in this suite relied heavily on resource functions present in tests/resources, all necessary ones have been implemented.
    - They include setup, cleanup and navigation functions
    - Helper functions for pulling, pushing, tagging etc. images to a project
  • All tests are independent and self-contained.
  • Integration with the existing Playwright configuration and GitHub Actions workflow.

Issue being fixed

Fixes #22134

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Test Migration Status

This is a tracker showing the status of the tests migrated successfully

bupd and others added 20 commits October 24, 2025 13:44
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>

fix: playwright github action

Signed-off-by: bupd <bupdprasanth@gmail.com>

fix: playwright github action

Signed-off-by: bupd <bupdprasanth@gmail.com>

fix: rename login logout test

Signed-off-by: bupd <bupdprasanth@gmail.com>

fix: playwright testing

Signed-off-by: bupd <bupdprasanth@gmail.com>

feat: correct test

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
@adityachopra29 adityachopra29 requested a review from a team as a code owner January 4, 2026 20:31
@adityachopra29 adityachopra29 changed the title Migration of Common_gc tests from Robot to Playwright for Github Actions Migration of Common_gc tests from Robot to Playwright Jan 5, 2026
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
…es with cosign helper functions

Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
…ions

Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
@adityachopra29
Copy link
Copy Markdown
Author

To the maintainers @bupd @Vad1mo @wy65701436 @OrlinVasilev. This pr is ready for review. Please take a look.

One thing to note here is that the tests Garbage Collection and Garbage Collection Accessory are check the working of the GC in different senarios, but GC does not consider artifacts uploaded in the past 2 hours, so it does not consider the project and artifacts that we push for testing.
Any suggestions on how to handle this?

@adityachopra29
Copy link
Copy Markdown
Author

Also, I found that there are a lot of different utility functions (for cosign/notation operations, docker functions, harbor navigation, etc) that I found will be used by other test cases as well, and everybody is reimplementing them for now...so I guess we need to modularize this at some point in time...so we should probably have an approach for this as well.
For now I have included them all in one file, but I can separate that out once the plan is decided. What do you suggest?

@adityachopra29
Copy link
Copy Markdown
Author

Lastly, currently, we don’t have a good developer setup for building Playwright tests. The playwright.yml file can’t be used to create a dev environment, which made local development inefficient for me. I’ve added a temporary workaround using sample.env, but a Docker-based setup similar to the Robot test cases would be a better long-term solution.

@bupd
Copy link
Copy Markdown
Member

bupd commented Jan 18, 2026

So currently the dev workflow is simple you just need to npm install which would install playwright

And for running playwright use npx playwright

On the sample env part and the playwright.yml this might be a good addition given that it simplifies the env required to run playwright tests locally

You can check the proposal i have linked the dockerfile for running playwright.

@adityachopra29
Copy link
Copy Markdown
Author

Okay..found the docker file

adityachopra29 and others added 2 commits January 19, 2026 12:28
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Copy link
Copy Markdown
Member

@bupd bupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd bupd requested a review from Copilot May 5, 2026 20:38
@bupd bupd added the release-note/infra Infra related changes e.g. release, test, ship etc... label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.02%. Comparing base (62c278d) to head (27feaa3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #22707   +/-   ##
=======================================
  Coverage   66.02%   66.02%           
=======================================
  Files        1074     1074           
  Lines      116793   116793           
  Branches     2955     2955           
=======================================
+ Hits        77109    77117    +8     
+ Misses      35410    35402    -8     
  Partials     4274     4274           
Flag Coverage Δ
unittests 66.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playwright release-note/infra Infra related changes e.g. release, test, ship etc... target/2.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Internal Pipeline to Github Actions

7 participants