feat: adding test helper and tests for project list

cmd/harbor/root/project/list_test.go

@@ -0,0 +1,61 @@
+// Copyright Project Harbor Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package project
+
+import (
+	"testing"
+
+	"github.com/goharbor/harbor-cli/pkg/testutil"
+)
+
+// TestListProjectCommand_Errors tests the custom validations we perform in the command,
+// testing of query builder and API response will be delegated to their respective places
+func TestListProjectCommand_Errors(t *testing.T) {
+	tests := []struct {
+		name        string
+		flags       []string
+		expectError bool
+	}{
+		{
+			name:        "negative page size",
+			flags:       []string{"--page-size", "-1"},
+			expectError: true,
+		},
+		{
+			name:        "page size too large",
+			flags:       []string{"--page-size", "101"},
+			expectError: true,
+		},
+		{
+			name:        "conflicting private and public flags",
+			flags:       []string{"--private", "--public"},
+			expectError: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			err := testutil.TestCmd(t, ListProjectCommand, tt.flags...)
+
+			if tt.expectError && err == nil {
+				t.Fatalf("expected error but got nil")
+			}
+
+			if !tt.expectError && err != nil {
+				t.Fatalf("unexpected error: %v", err)
+			}
+		})
+	}
+}

pkg/testutil/testutil.go

@@ -0,0 +1,33 @@
+// Copyright Project Harbor Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package testutil
+
+import (
+	"testing"
+
+	"github.com/spf13/cobra"
+)
+
+func TestCmd(t *testing.T, cmdFunc func() *cobra.Command, flags ...string) error {
+	t.Helper()
+
+	cmd := cmdFunc()
+	cmd.SetArgs(flags)
+
+	// Stops default cobra logs
+	cmd.SilenceUsage = true
+	cmd.SilenceErrors = true
+
+	return cmd.Execute()
+}