-
-
Notifications
You must be signed in to change notification settings - Fork 2k
🔥 feat: Add URL() method to Route for generating URLs with parameters #4195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Claude
wants to merge
15
commits into
main
Choose a base branch
from
claude/fix-getroute-path-param
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
daa7dc9
Initial plan
Claude db31cdf
Add URL() method to Route for generating URLs with parameters
Claude 26faa1d
fix: address review feedback on Route.URL() - deterministic lookup, c…
Copilot 6b37d8d
fix: nil guard, deterministic case-insensitive fallback, mounted rout…
Copilot 434c6f2
refactor: extract shared buildRouteURL helper, add deterministic fall…
Copilot 9fef978
fix: refine Route.URL greedy fallback and docs
Copilot be74496
test: cover default greedy fallback path
Copilot 6d6740e
perf: avoid greedy fallback slice allocations
Copilot 6e56f99
docs: clarify greedy fallback helper behavior
Copilot 2e241ed
docs: explain Route.URL fallback edge cases
Copilot a7f3f1f
perf: precompute greedy fallback map keys
Copilot 9b47da0
refactor: rename default greedy fallback keys
Copilot 389a0f6
🐛 fix: make Route.URL callable on GetRoute values
Copilot 3384a5b
🧹 chore: clarify Route.URL nolint rationale
Copilot afc8c17
🧹 chore: fix Route.URL comment casing
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.