Skip to content

chore: Improve error messages in SaveFileToStorage #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pratikramteke wants to merge 7 commits into
base: main
Choose a base branch
from
+53 −5
Open

chore: Improve error messages in SaveFileToStorage #4173

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
80e0203
improve error messages in SaveFileToStorage
pratikramteke Apr 1, 2026
485129f
Apply suggestion from @gemini-code-assist[bot]
pratikramteke Apr 1, 2026
23f1d53
Apply suggestion from @gemini-code-assist[bot]
pratikramteke Apr 1, 2026
240b1ad
Apply suggestion from @gemini-code-assist[bot]
pratikramteke Apr 1, 2026
d310941
test: add nil check and error message tests for SaveFileToStorage
pratikramteke Apr 2, 2026
3364650
Merge branch 'main' into improve-error-messages
pratikramteke Apr 2, 2026
3d08591
test: add nil fileheader test for SaveFile
pratikramteke Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ctx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ func (*DefaultCtx) SaveFile(fileheader *multipart.FileHeader, path string) error
func (c *DefaultCtx) SaveFileToStorage(fileheader *multipart.FileHeader, path string, storage Storage) error {
file, err := fileheader.Open()
if err != nil {
return fmt.Errorf("failed to open: %w", err)
return fmt.Errorf("failed to open file %s: %w", fileheader.Filename, err)
Copy link
Copy Markdown
Member

@efectn efectn Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the fileader is nil, it is going to panic. you also need to add check for that. In addition to panic check, could you also unit test cases for error messages?

Copy link
Copy Markdown
Member

@gaby gaby Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't err have the filename already?

Copy link
Copy Markdown
Member

@efectn efectn Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it only shows what the error is https://pkg.go.dev/internal/oserror#pkg-variables

}
defer file.Close() //nolint:errcheck // not needed

Expand All @@ -529,25 +529,25 @@ func (c *DefaultCtx) SaveFileToStorage(fileheader *multipart.FileHeader, path st
}

if fileheader.Size > 0 && fileheader.Size > int64(maxUploadSize) {
return fmt.Errorf("failed to read: %w", fasthttp.ErrBodyTooLarge)
return fmt.Errorf("failed to read file %s: %w", fileheader.Filename, fasthttp.ErrBodyTooLarge)
}

buf := bytebufferpool.Get()
defer bytebufferpool.Put(buf)

limitedReader := io.LimitReader(file, int64(maxUploadSize)+1)
if _, err = buf.ReadFrom(limitedReader); err != nil {
return fmt.Errorf("failed to read: %w", err)
return fmt.Errorf("failed to read file %s: %w", fileheader.Filename, err)
}

if buf.Len() > maxUploadSize {
return fmt.Errorf("failed to read: %w", fasthttp.ErrBodyTooLarge)
return fmt.Errorf("failed to read file %s: %w", fileheader.Filename, fasthttp.ErrBodyTooLarge)
}

data := append([]byte(nil), buf.Bytes()...)

if err := storage.SetWithContext(c.Context(), path, data, 0); err != nil {
return fmt.Errorf("failed to store: %w", err)
return fmt.Errorf("failed to store file %s at %s: %w", fileheader.Filename, path, err)
}

return nil
Expand Down
Loading