Skip to content

🐛 bug: harden session middleware lifecycle and error handling #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaby merged 2 commits into from
Feb 24, 2026

🐛 bug: validate session IDs, use StoreInContext for cleanup, remove p…

a7fdf2c
Select commit
Loading
Failed to load commit list.
Merged

🐛 bug: harden session middleware lifecycle and error handling #4107

🐛 bug: validate session IDs, use StoreInContext for cleanup, remove p…
a7fdf2c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 24, 2026 in 0s

91.13% (-0.03%) compared to a5953ea

View this Pull Request on Codecov

91.13% (-0.03%) compared to a5953ea

Details

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.13%. Comparing base (a5953ea) to head (a7fdf2c).

Files with missing lines Patch % Lines
middleware/session/data.go 40.00% 2 Missing and 1 partial ⚠️
middleware/session/session.go 33.33% 1 Missing and 1 partial ⚠️
middleware/session/middleware.go 50.00% 1 Missing ⚠️
middleware/session/store.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                               Coverage Diff                                @@
##           update-session-middleware-to-fail-gracefully    #4107      +/-   ##
================================================================================
- Coverage                                         91.15%   91.13%   -0.03%     
================================================================================
  Files                                               119      119              
  Lines                                             11354    11367      +13     
================================================================================
+ Hits                                              10350    10359       +9     
- Misses                                              636      638       +2     
- Partials                                            368      370       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov