Skip to content

Handle Ctrl and Alt to fold nodes recursively with mouse input - #40446

Closed
Xrayez wants to merge 1 commit into
godotengine:masterfrom
Xrayez:collapse-cure-all
Closed

Handle Ctrl and Alt to fold nodes recursively with mouse input#40446
Xrayez wants to merge 1 commit into
godotengine:masterfrom
Xrayez:collapse-cure-all

Conversation

@Xrayez

@Xrayez Xrayez commented Jul 16, 2020

Copy link
Copy Markdown
Contributor

Closes #28626.

Either Ctrl, Shift, or Alt need to be pressed to recursively collapse/expand nodes in the scene tree dock combined with the mouse input now. This should hopefully cover all cases, and it's safe to handle those for the TreeItem folding arrow input.

Either <kbd>Ctrl</kbd>, <kbd>Shift</kbd>, or <kbd>Alt</kbd> need to be
pressed to recursively collapse/expand nodes in the scene tree dock now.
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Jul 16, 2020
@Calinou Calinou added this to the 4.0 milestone Jul 16, 2020
@Xrayez

Xrayez commented Jul 17, 2020

Copy link
Copy Markdown
Contributor Author

As suggested in #28626 (comment), yeah it makes sense to only handle Alt then, but if you'd like this change to be cherry-picked to 3.2 without "breaking compat" by breaking expectations in 3.2, better merge this and then do the necessary changes to only allow Alt in master perhaps.

@aaronfranke

Copy link
Copy Markdown
Member

@Xrayez Is this still desired? If so, it needs to be rebased and tested on the latest master branch. While there are no conflicts, rebasing is important so that reviewers can easily test the PR.

@Xrayez

Xrayez commented Feb 27, 2021

Copy link
Copy Markdown
Contributor Author

I'm not sure if there's any consensus on this, otherwise it's worth a rebase. 🙂

I'm totally fine with current approach myself, though.

@Calinou

Calinou commented Mar 10, 2021

Copy link
Copy Markdown
Member

There's #36926 which provides similar functionality, although its scope is larger.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Collapse / Expand All doesn't work with mouse input

4 participants