Skip to content

Remove unused variable in editor_properties.cpp - #114454

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
ASamBlur:remove-unused-line-in-editor_properties
Jan 28, 2026
Merged

Remove unused variable in editor_properties.cpp#114454
Repiteo merged 1 commit into
godotengine:masterfrom
ASamBlur:remove-unused-line-in-editor_properties

Conversation

@ASamBlur

Copy link
Copy Markdown
Contributor

After #108065 there is no need to declare the hint variable here.

case Variant::BASIS: {
EditorPropertyBasis *editor = memnew(EditorPropertyBasis);
EditorPropertyRangeHint hint = _parse_range_hint(p_hint, p_hint_text, default_float_step);
editor->setup(_parse_range_hint(p_hint, p_hint_text, default_float_step));
return editor;
} break;

@ASamBlur
ASamBlur requested a review from a team December 30, 2025 18:34

@HolonProduction HolonProduction left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles it compiles. _parse_range_hint has no side effects either.

@akien-mga akien-mga changed the title Remove unused line in editor_properties.cpp Remove unused variable in editor_properties.cpp Jan 1, 2026
@akien-mga akien-mga added this to the 4.7 milestone Jan 1, 2026
@Repiteo
Repiteo merged commit db8b809 into godotengine:master Jan 28, 2026
20 checks passed
@Repiteo

Repiteo commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@ASamBlur
ASamBlur deleted the remove-unused-line-in-editor_properties branch January 29, 2026 08:54
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
…e-in-editor_properties

Remove unused variable in `editor_properties.cpp`
BendyLand pushed a commit to BendyLand/voltaire that referenced this pull request Aug 2, 2026
…e-in-editor_properties

Remove unused variable in `editor_properties.cpp`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants