Set up labeler.yml file for github labeler actions - #12016
Conversation
Mickeon
left a comment
There was a problem hiding this comment.
With the way labels are configured in this repository, this is pretty much a no-brainer as it saves a lot of maintenance time. It's worth a deeper look from others.
| # Commented out due to ongoing changes with the change to hte asset store | ||
| #topic:assetstore: | ||
| #- changed-files: | ||
| # - any-glob-to-any-files: community/asset_library/** |
There was a problem hiding this comment.
Perhaps you should still have topic:assetlib for the time being.
| # Commented out due to ongoing changes with the change to hte asset store | |
| #topic:assetstore: | |
| #- changed-files: | |
| # - any-glob-to-any-files: community/asset_library/** | |
| topic:assetlib: | |
| - changed-files: | |
| - any-glob-to-any-files: community/asset_library/** |
Perhaps you could write a TODO to change it later once new pages are ready for the Asset Store, instead.
| #Unsure if this would apply to all compiling pages or not | ||
| #topic:buildsystem: | ||
| #- changed-files: | ||
| # - any-glob-to-any-files: |
There was a problem hiding this comment.
I'm not sure why not? Which pages in engine_details/development/compiling are debatably not part of topic:buildsystem?
We could use a few past PRs as a point of reference, like:
- Update build tools requirements. #11976
- Add spaces to SConstruct snippet #11169
- Repiteo then labelled CI: Fix
sync_class_ref.ymlworkflow #11535 , but in this casetopic:buildsystemis used to refer to the documentation's buildsystem itself, rather than Godot Engine's. - A similar case in Add CODEOWNERS #11401, as well.
|
Fixed |
|
Similar to Mickeon (and as discussed on RC), I think this is a great idea and could save us quite a bit of time and manual work. I gave it a review and it looks fine as is, but its also fine to iteratively improve further if something crops up in practice. I'm fine with merging as is, but we can also leave this open a few days more to give others a chance to chime in. Especially @AThousandShips and @Calinou :) |
AThousandShips
left a comment
There was a problem hiding this comment.
I'd also suggest adding the classes folder under area:class reference to more easily catch errors posting such PRs
Also would be good to confirm this works with labels with spaces in them or if we need to handle that specially
Calinou
left a comment
There was a problem hiding this comment.
Should be good to merge after applying suggestions.
I agree autolabeling makes sense to save some time. However, the downside is that organization members can no longer easily find unlabeled issues that should be labeled by searching for no:label. I guess we should test drive it and revert it if this proves to be problematic.
|
added a newline to the end of the file, and added the class reference label |
labeler.yml file for github labeler actions
|
Lets give this a try then, merged. Thank you! PR for the GH action welcome. |
Github has an action available called labeler (details here), which can be used to automatically label pull requests based on what files are modified.
This file has been setup for automatically assigning area and topic labels (for example area:manual, topic:3d).
This is not a replacement for Triage, labels such as enhancement and bugfix still need to be manually determined, and there's pages where multiple labels could apply so things can't be setup automatically (for example compiling with Xcode)
Once this PR is merged an action will need to be setup to run when a PR is opened.