Skip to content

Set up labeler.yml file for github labeler actions - #12016

Merged
mhilbrunner merged 1 commit into
godotengine:masterfrom
skyace65:github-labeler
Jun 6, 2026
Merged

Set up labeler.yml file for github labeler actions#12016
mhilbrunner merged 1 commit into
godotengine:masterfrom
skyace65:github-labeler

Conversation

@skyace65

Copy link
Copy Markdown
Member

Github has an action available called labeler (details here), which can be used to automatically label pull requests based on what files are modified.

This file has been setup for automatically assigning area and topic labels (for example area:manual, topic:3d).

This is not a replacement for Triage, labels such as enhancement and bugfix still need to be manually determined, and there's pages where multiple labels could apply so things can't be setup automatically (for example compiling with Xcode)

Once this PR is merged an action will need to be setup to run when a PR is opened.

@skyace65
skyace65 requested a review from a team as a code owner May 25, 2026 14:23
@skyace65 skyace65 added the content:website Issues related to adding website features and fixing bugs, whether on the front or back-end label May 25, 2026

@Mickeon Mickeon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the way labels are configured in this repository, this is pretty much a no-brainer as it saves a lot of maintenance time. It's worth a deeper look from others.

Comment thread .github/labeler.yml Outdated
Comment on lines +96 to +99
# Commented out due to ongoing changes with the change to hte asset store
#topic:assetstore:
#- changed-files:
# - any-glob-to-any-files: community/asset_library/**

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you should still have topic:assetlib for the time being.

Suggested change
# Commented out due to ongoing changes with the change to hte asset store
#topic:assetstore:
#- changed-files:
# - any-glob-to-any-files: community/asset_library/**
topic:assetlib:
- changed-files:
- any-glob-to-any-files: community/asset_library/**

Perhaps you could write a TODO to change it later once new pages are ready for the Asset Store, instead.

Comment thread .github/labeler.yml Outdated
Comment on lines +105 to +108
#Unsure if this would apply to all compiling pages or not
#topic:buildsystem:
#- changed-files:
# - any-glob-to-any-files:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why not? Which pages in engine_details/development/compiling are debatably not part of topic:buildsystem?

We could use a few past PRs as a point of reference, like:

@skyace65

Copy link
Copy Markdown
Member Author

Fixed

@mhilbrunner

mhilbrunner commented May 30, 2026

Copy link
Copy Markdown
Member

Similar to Mickeon (and as discussed on RC), I think this is a great idea and could save us quite a bit of time and manual work. I gave it a review and it looks fine as is, but its also fine to iteratively improve further if something crops up in practice.

I'm fine with merging as is, but we can also leave this open a few days more to give others a chance to chime in. Especially @AThousandShips and @Calinou :)

@AThousandShips AThousandShips left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also suggest adding the classes folder under area:class reference to more easily catch errors posting such PRs

Also would be good to confirm this works with labels with spaces in them or if we need to handle that specially

Comment thread .github/labeler.yml Outdated

@Calinou Calinou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge after applying suggestions.

I agree autolabeling makes sense to save some time. However, the downside is that organization members can no longer easily find unlabeled issues that should be labeled by searching for no:label. I guess we should test drive it and revert it if this proves to be problematic.

@skyace65

skyace65 commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

added a newline to the end of the file, and added the class reference label

@AThousandShips AThousandShips left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AThousandShips AThousandShips changed the title setup labeler.yml file for github labeler actions Set up labeler.yml file for github labeler actions Jun 5, 2026
@mhilbrunner
mhilbrunner merged commit 81d49d5 into godotengine:master Jun 6, 2026
1 check passed
@mhilbrunner

mhilbrunner commented Jun 6, 2026

Copy link
Copy Markdown
Member

Lets give this a try then, merged. Thank you! PR for the GH action welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:website Issues related to adding website features and fixing bugs, whether on the front or back-end enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants