Repository navigation
Conversation
sameerihs
marked this pull request as ready for review
November 8, 2026 17:58
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
=======================================
Coverage 80.65% 80.66%
=======================================
Files 22 22
Lines 6845 6847 +2
=======================================
+ Hits 5521 5523 +2
Misses 905 905
Partials 419 419 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, please confirm the following.
Fixes #419.
Adding a line comment with
WithCommentto an empty sequence emitsitems # comment: [], putting the mapping delimiter and value inside thecomment. Explicit flow-style sequences have the same problem.
Attach these comments to the sequence so its existing renderer places them
after
]. ExtendTest_WithCommentOptionwith empty slices, nil slices,empty arrays, flow sequences and a block-sequence control. The tests check
exact output and decode it back to the expected value. Four cases fail before
the fix; all five pass afterward.
Validation with Go 1.24.4 on macOS arm64:
make test,make simple-test,make lintwith pinned golangci-lint 2.1.2,make fuzzandmake cover.TypeScript and Vite builds.
go vet ./..., formatting and diff checks.An additional vet run including
./testdatareports seven existing unkeyedMapItemliterals, reproduced on unchanged upstream. The playground build usedNode 26 rather than CI's Node 20; the full CI platform/version matrix remains
unverified locally.