Skip to content

fix: handle -1 from syscall.Read #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvainio wants to merge 1 commit into from
Closed

fix: handle -1 from syscall.Read #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions serial_posix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,14 @@ func (p *port) Read(b []byte) (n int, err error) {
return
}
n, err = syscall.Read(fd, b)
if n < 0 {
// underlying syscall.Read returns -1 on error, but we want to return 0 to be consistent with io.Reader interface.
if err == nil {
// This should not happen, but just in case.
err = fmt.Errorf("serial: read returned %v without error", n)
}
n = 0
}
return
}

Expand Down