packages/ak-common/tracing: get sentry config from API for outposts#21625
packages/ak-common/tracing: get sentry config from API for outposts#21625
Conversation
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21625 +/- ##
==========================================
- Coverage 92.29% 92.22% -0.08%
==========================================
Files 1032 1033 +1
Lines 59767 59925 +158
Branches 2537 2695 +158
==========================================
+ Hits 55162 55265 +103
- Misses 4540 4587 +47
- Partials 65 73 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-81f8d2ac3e5ff947fa638d48391207fd5555fc6d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-81f8d2ac3e5ff947fa638d48391207fd5555fc6dAfterwards, run the upgrade commands from the latest release notes. |
| let base_path = if ak_host.ends_with('/') { | ||
| format!("{ak_host}api/v3") | ||
| } else { | ||
| format!("{ak_host}/api/v3") | ||
| }; |
There was a problem hiding this comment.
I'd prefer if we used a real URL parsing/manipulation instead of string-based
There was a problem hiding this comment.
I actually do exactly that right after with host.parse(), which will automatically set the path to / if there are not trailing /, so yeah, fixed
There was a problem hiding this comment.
actually I'll improve a bit more and do the same for the base url for the client, standby
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Details
REPLACE ME
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen)If changes to the frontend have been made
make web)If applicable
make docs)