Skip to content

packages/ak-common/tracing: get sentry config from API for outposts#21625

Merged
rissson merged 9 commits intomainfrom
ak-common-get-sentry-config-from-api-for-outposts
Apr 16, 2026
Merged

packages/ak-common/tracing: get sentry config from API for outposts#21625
rissson merged 9 commits intomainfrom
ak-common-get-sentry-config-from-api-for-outposts

Conversation

@rissson
Copy link
Copy Markdown
Member

@rissson rissson commented Apr 15, 2026

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema and clients have been updated (make gen)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make docs)

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson self-assigned this Apr 15, 2026
@rissson rissson requested a review from a team as a code owner April 15, 2026 15:12
@rissson rissson moved this from Todo to Needs review in authentik Core Apr 15, 2026
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2026

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 6929e23
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/69dfaad1855f4c000852af25
😎 Deploy Preview https://deploy-preview-21625--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 68.45238% with 53 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.22%. Comparing base (668f37e) to head (81f8d2a).
⚠️ Report is 12 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/ak-common/src/tracing.rs 13.20% 45 Missing and 1 partial ⚠️
packages/ak-common/src/api.rs 93.75% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21625      +/-   ##
==========================================
- Coverage   92.29%   92.22%   -0.08%     
==========================================
  Files        1032     1033       +1     
  Lines       59767    59925     +158     
  Branches     2537     2695     +158     
==========================================
+ Hits        55162    55265     +103     
- Misses       4540     4587      +47     
- Partials       65       73       +8     
Flag Coverage Δ
conformance 36.98% <ø> (+<0.01%) ⬆️
e2e 42.90% <ø> (+<0.01%) ⬆️
integration 33.90% <ø> (+<0.01%) ⬆️
rust 60.55% <68.45%> (+0.05%) ⬆️
unit 91.92% <ø> (+<0.01%) ⬆️
unit-migrate 92.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rissson rissson mentioned this pull request Apr 15, 2026
rissson added 2 commits April 15, 2026 17:21
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-81f8d2ac3e5ff947fa638d48391207fd5555fc6d
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-81f8d2ac3e5ff947fa638d48391207fd5555fc6d

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Comment thread packages/ak-common/src/api.rs Outdated
Comment on lines +20 to +24
let base_path = if ak_host.ends_with('/') {
format!("{ak_host}api/v3")
} else {
format!("{ak_host}/api/v3")
};
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we used a real URL parsing/manipulation instead of string-based

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do exactly that right after with host.parse(), which will automatically set the path to / if there are not trailing /, so yeah, fixed

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I'll improve a bit more and do the same for the base url for the client, standby

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and I've added tests 🎉

Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@rissson rissson requested a review from BeryJu April 15, 2026 15:52
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 15, 2026

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 28fff0d
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/69dfb43b9c7e8a00088b7e69
😎 Deploy Preview https://deploy-preview-21625--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

rissson added 3 commits April 15, 2026 18:06
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
@github-project-automation github-project-automation Bot moved this from Needs review to In Progress in authentik Core Apr 16, 2026
@rissson rissson merged commit 1b53426 into main Apr 16, 2026
111 of 112 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in authentik Core Apr 16, 2026
@rissson rissson deleted the ak-common-get-sentry-config-from-api-for-outposts branch April 16, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants