web/elements: default @listen target to host element and add split-button Dropdown#21512
Merged
GirlBossRush merged 3 commits intomainfrom Apr 11, 2026
Merged
web/elements: default @listen target to host element and add split-button Dropdown#21512GirlBossRush merged 3 commits intomainfrom
GirlBossRush merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21512 +/- ##
==========================================
+ Coverage 92.21% 92.28% +0.06%
==========================================
Files 1032 1032
Lines 59658 59658
Branches 2537 2537
==========================================
+ Hits 55013 55053 +40
+ Misses 4580 4542 -38
+ Partials 65 63 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kensternberg-authentik
approved these changes
Apr 9, 2026
Contributor
kensternberg-authentik
left a comment
kensternberg-authentik
left a comment
There was a problem hiding this comment.
Tsk! This could still have been two PRs (@listen and Dropdown), but it's small enough.
One thing I'm not clear on is what's different between the @listen listener and all the individual listeners? Also, one thing that I've learned recently is that if you have a listener on window that triggers a method in your component, that component will never be garbage collected if removed from the DOM until the listener is removed, since it has a hard reference to your component. If we need to track "clicks outside," we should probably look at how other people have done it and find a technique with weaker references.
| // }); | ||
| // } | ||
| for (const menuItemButton of menuItemButtons) { | ||
| menuItemButton.addEventListener("click", this.hide, { |
Contributor
There was a problem hiding this comment.
All right, gonna be a butthead here and ask: why can't we do this as a top-level listener, get the event target and ask for an ID or some other referent? Then you could just build the click listener on construction, and not have to worry about abort controllers at all.
GirlBossRush
force-pushed
the
web/listen-default-dropdown
branch
from
f90ce43 to
6613f37
Compare
Contributor
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-a58d9fe938444647bedaa8284e0e02b23e1ec1cf
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-a58d9fe938444647bedaa8284e0e02b23e1ec1cfAfterwards, run the upgrade commands from the latest release notes. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…ment Change the `@listen` decorator default target from `window` to `this` so listeners bind to the host element by default — the more common case for Lit components. Add explicit `target: window` to the five existing call sites that dispatch on the window (ak-interface-admin, APIDrawer, SidebarItem, FlowExecutor, and Dropdown's own refresh listener). Also add split-button support to the Dropdown component with `SplitButtonSelector` / `ToggleButtonSelector` statics and corresponding CSS padding variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
GirlBossRush
force-pushed
the
web/listen-default-dropdown
branch
from
d9c94c7 to
a58d9fe
Compare
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 13, 2026
* main: core: bump ruff from 0.15.9 to 0.15.10 (#21559) core: bump types-jwcrypto from 1.5.0.20260408 to 1.5.7.20260409 (#21561) core: bump lxml from 6.0.3 to 6.0.4 (#21560) ci: bump peter-evans/create-pull-request from 8.1.0 to 8.1.1 (#21566) ci: bump docker/build-push-action from 7.0.0 to 7.1.0 (#21563) ci: bump actions/upload-artifact from 7.0.0 to 7.0.1 (#21565) core: bump library/golang from `da39430` to `c0074c7` in /lifecycle/container (#21567) ci: bump taiki-e/install-action from 2.75.1 to 2.75.5 in /.github/actions/setup (#21569) web: bump mermaid from 11.13.0 to 11.14.0 in /web (#21527) core, web: update translations (#21552) web: bump basic-ftp from 5.2.1 to 5.2.2 in /web (#21543) web: User Wizard, Modal Revisions Merge Branch (#21336) web/elements: default @listen target to host element and add split-button Dropdown (#21512)
kensternberg-authentik
added a commit
that referenced
this pull request
Apr 13, 2026
* main: web: build system had some legacy stuff that I found confusing while working on the CSS ordering (#20698) core: bump ruff from 0.15.9 to 0.15.10 (#21559) core: bump types-jwcrypto from 1.5.0.20260408 to 1.5.7.20260409 (#21561) core: bump lxml from 6.0.3 to 6.0.4 (#21560) ci: bump peter-evans/create-pull-request from 8.1.0 to 8.1.1 (#21566) ci: bump docker/build-push-action from 7.0.0 to 7.1.0 (#21563) ci: bump actions/upload-artifact from 7.0.0 to 7.0.1 (#21565) core: bump library/golang from `da39430` to `c0074c7` in /lifecycle/container (#21567) ci: bump taiki-e/install-action from 2.75.1 to 2.75.5 in /.github/actions/setup (#21569) web: bump mermaid from 11.13.0 to 11.14.0 in /web (#21527) core, web: update translations (#21552) web: bump basic-ftp from 5.2.1 to 5.2.2 in /web (#21543) web: User Wizard, Modal Revisions Merge Branch (#21336) web/elements: default @listen target to host element and add split-button Dropdown (#21512) ci: parallel tests (#21515) website/docs: add another sentence to First Steps about restricting access to apps (#21517) web/elements: add scrollbar helpers and apply to Interface (#21511) web/elements: add viewport helpers and extend intersection observer (#21508)
davepgreene
pushed a commit
to davepgreene/authentik
that referenced
this pull request
Apr 13, 2026
…tton Dropdown (goauthentik#21512) web/buttons: support split-button Dropdown and default @listen to element Change the `@listen` decorator default target from `window` to `this` so listeners bind to the host element by default — the more common case for Lit components. Add explicit `target: window` to the five existing call sites that dispatch on the window (ak-interface-admin, APIDrawer, SidebarItem, FlowExecutor, and Dropdown's own refresh listener). Also add split-button support to the Dropdown component with `SplitButtonSelector` / `ToggleButtonSelector` statics and corresponding CSS padding variables. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
davepgreene
pushed a commit
to davepgreene/authentik
that referenced
this pull request
Apr 13, 2026
…tton Dropdown (goauthentik#21512) web/buttons: support split-button Dropdown and default @listen to element Change the `@listen` decorator default target from `window` to `this` so listeners bind to the host element by default — the more common case for Lit components. Add explicit `target: window` to the five existing call sites that dispatch on the window (ak-interface-admin, APIDrawer, SidebarItem, FlowExecutor, and Dropdown's own refresh listener). Also add split-button support to the Dropdown component with `SplitButtonSelector` / `ToggleButtonSelector` statics and corresponding CSS padding variables. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@listendecorator default target fromwindowtothis— host-scoped listeners are the more common case for Lit componentstarget: windowto the five existing call sites that dispatch on the window (ak-interface-admin,APIDrawer,SidebarItem,FlowExecutor, and Dropdown's own refresh listener)SplitButtonSelector/ToggleButtonSelectorstatics and corresponding CSS padding variablesTest plan
Split from web/a11y: Modal revisions, behavior fixes #21206 to ease review.