fix: support SOCKS5 UDP associations over MASQUE - #119
Open
Niek wants to merge 3 commits into
Open
Conversation
Niek
marked this pull request as ready for review
August 4, 2026 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PacketConnwhen MASQUE receives a destinationless UDP association:protocolpseudo-headerThe SOCKS5 handler establishes UDP associations with
Router.Dial(ctx, "udp", ""). MASQUE previously passed that empty address toSplitHostPort, so UDP ASSOCIATE failed before the SOCKS5 success reply. Each destination now gets its own CONNECT-UDP stream; a refused or reset destination is dropped and can be re-dialed without terminating the shared association. Clients requiring IP-form SOCKS5 replies can use the existingudp.resolveDomainhandler option.Related to go-gost/gost#793.
Validation
go test -race ./connector/masque ./dialer/http3/masque ./internal/util/masquego vet ./connector/masque ./dialer/http3/masque ./internal/util/masqueudp.resolveDomain:https://google.com/generate_204returned204over CDP protocolh3