-
Notifications
You must be signed in to change notification settings - Fork 455
feat(gnoland): add block_height and chain_id to GnoTxMetadata #5390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -134,7 +134,9 @@ type TxWithMetadata struct { | |
| } | ||
|
|
||
| type GnoTxMetadata struct { | ||
| Timestamp int64 `json:"timestamp"` | ||
| Timestamp int64 `json:"timestamp"` | ||
| BlockHeight int64 `json:"block_height,omitempty"` | ||
| ChainID string `json:"chain_id,omitempty"` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you planning to use the I see it’s being populated on the Either way, it’d be good to add a comment explaining why this field is there.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The goal is to ensure the exported value is complete for validating signatures and replaying under similar conditions. We aim to use it as soon as it makes sense, but we want to make it available now to ensure completeness. |
||
| } | ||
|
|
||
| // ReadGenesisTxs reads the genesis txs from the given file path | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.