Skip to content

Fix a bug in replace-one when options are not passed #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaszkorecki wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a bug in replace-one when options are not passed #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/mongo_driver_3/collection.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@
([^MongoDatabase db coll q]
(find db coll q {}))
([^MongoDatabase db coll q {:keys [limit skip sort projection ^ClientSession session keywordize? raw? realise-fn]
:or {keywordize? true
:or {keywordize? true
realise-fn sequence}
:as opts}]
(let [^ClientSession session (or session *session*)
Expand All @@ -215,7 +215,7 @@
sort (.sort (document sort))
projection (.projection (document projection)))]

(if raw?
(if raw?
it
(realise-fn ;; accomodate users who don't want to use lazy-seqs
(iterable/documents it keywordize?))))))
Expand Down Expand Up @@ -366,7 +366,7 @@

Additionally takes options specified in `collection`"
([^MongoDatabase db coll q doc]
(find-one-and-replace db coll q doc {}))
(replace-one db coll q doc {}))
([^MongoDatabase db coll q doc opts]
(if-let [^ClientSession session (or (:session opts) *session*)]
(.replaceOne (collection db coll opts) session (document q) (document doc) (->ReplaceOptions opts))
Expand Down Expand Up @@ -512,5 +512,5 @@
([^MongoDatabase db coll opts]
(let [it (.listIndexes (collection db coll opts))
realise-fn (:realise-fn opts sequence)]
(realise-fn
(iterable/documents it true)))))
(realise-fn
(iterable/documents it true)))))