Update decompressor.cpp#7
Conversation
|
good catch @sanyam188, just one more change. it is good to discover other cases than given in the discription of issue. I have written that it fails on Good luck and I hope to see another commit over this PR :) |
|
Thanks Sarbjit sir for taking your time out and informing about my
mistakes. I will definitely give my best to do further commits to this
project. Looking forward to hear from you again.
…On Mon, Sep 24, 2018, 2:55 PM srb cheema ***@***.***> wrote:
good catch @sanyam188 <https://github.com/sanyam188>, just one more
change. it is good to discover other cases than given in the discription of
issue. I have written that it fails on empty file but that was not the
only problem. I have left the other cases for the solvers. you did really
well by finding out the location of the problem.
The other cases are that it will also fail on file size less than 5 words
(not only empty file). Sometimes it happens that issue reporter reports the
issue with less information it is duty of contributers to detect the root
cause of problem and try to fix all the cases including those not listed
in issue
Good luck and I hope to see another commit over this PR :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AibHFdLIkAz-v41e1iE5J1op6mWVI3f4ks5ueKT4gaJpZM4W1Jta>
.
|
|
Great @sanyam188 Happy Contributing :) |
No description provided.