You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
good catch @no-one-21,
You have found the location of the problem easily. there is some problem in implementing the technique.
Whenever you solve an issue try to figure the main cause of the issue. not the only one described in description.
it is good to discover other cases than given in the discription of issue. I have written that it fails on empty file but that was not the only problem. I have left the other cases for the solvers. you did really well by finding out the location of the problem.
The other cases are that it will also fail on file size less than 5 words (not only empty file). Sometimes it happens that issue reporter reports the issue with less information it is duty of contributers to detect the root cause of problem and try to fix all the cases including those not listed in issue
One more thing never miss description of you PR
Good luck and I hope to see another commit over this PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.