Skip to content

fix: :config_edit open editor not video player #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
suveshmoza wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −1
Draft

fix: :config_edit open editor not video player #269

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
764681e
fix: :config_edit open editor not video player
suveshmoza Mar 6, 2026
d03974f
open config file with OS default handler for .ts files
suveshmoza Mar 8, 2026
ca4fa59
revert back
suveshmoza Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/glide/browser/base/content/browser-excmds.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ class GlideExcmdsClass {

const file = Cc["@mozilla.org/file/local;1"]!.createInstance(Ci.nsIFile);
file.initWithPath(GlideBrowser.config_path);
file.launch();
launch_as_text(file);
break;
}

Expand Down Expand Up @@ -1042,3 +1042,14 @@ export function get_command_info(
}

export const GlideExcmds = new GlideExcmdsClass();

function launch_as_text(file: nsIFile): void {
try {
const mime_service = Cc["@mozilla.org/mime;1"]!.getService(Ci.nsIMIMEService);
const mime_info = mime_service.getFromTypeAndExtension("text/plain", "");
mime_info.preferredAction = Ci.nsIHandlerInfo.useSystemDefault;
mime_info.launchWithFile(file);
} catch {
Copy link
Copy Markdown
Member

@RobertCraigie RobertCraigie Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: did you run into any errors while testing this or is this just defensive?

Copy link
Copy Markdown
Contributor Author

@suveshmoza suveshmoza Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being defensive here. I didn’t run into any errors during testing, but added in case it throws.

file.launch();
}
}