feat(nix): ignore nixos test history#4837
Merged
dooleydevin merged 1 commit intogithub:mainfrom Apr 6, 2026
Merged
Conversation
dooleydevin
reviewed
Apr 6, 2026
Collaborator
dooleydevin
left a comment
dooleydevin
left a comment
There was a problem hiding this comment.
Thanks for the contribution @haras-unicorn! I left one suggestion that may apply here. I'll check back on this tomorrow and approve/merge it whether or not that update is committed 👍
Nix.gitignore
Outdated
| .direnv | ||
|
|
||
| # Ignore NixOS interactive test driver history | ||
| .nixos-test-history |
Collaborator
There was a problem hiding this comment.
Based on the snippet you provided, it looks like this file shows up in the working directory of wherever the command is run. I'm not too familiar with the tooling, but if that's common you might want this to match in subdirectories too:
Suggested change
| .nixos-test-history | |
| **/.nixos-test-history |
Contributor
Author
There was a problem hiding this comment.
oh right thx :) - i force pushed ur suggestion
haras-unicorn
force-pushed
the
feat-nix-ignore-nixos-test-history
branch
from
6ae5564 to
c5bf3ca
Compare
dooleydevin
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
When testing NixOS modules, the interactive test driver leaves us with the
.nixos-test-historyfile. This is common for anyone making NixOS module tests.Links to documentation supporting these rule changes
This file doesn't seem to be official but here is the line of code which creates it:
If this is a new template
This is not a new template.
Merge and Approval Steps