Skip to content

[WIP] Fix template injection error in sync-actions.yml #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Mar 11, 2026
Merged

[WIP] Fix template injection error in sync-actions.yml #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e51a19
Initial plan
Copilot Mar 11, 2026
ca832b4
fix: prevent template injection by passing inputs.ref via env var in …
Copilot Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/sync-actions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
echo "::group::Resolving Ref"

# Determine raw ref from event inputs
RAW_REF="${{ inputs.ref }}"
RAW_REF="${INPUT_REF}"

# Default to 'latest' if empty
if [[ -z "$RAW_REF" ]]; then
Expand Down Expand Up @@ -187,6 +187,7 @@ jobs:
echo "::endgroup::"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
INPUT_REF: ${{ inputs.ref }}
Comment on lines 188 to +190
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change prevents expression interpolation of inputs.ref in the "Resolve ref" step, but the workflow still directly expands ${{ inputs.ref }} inside a run: script in the earlier "Log workflow context" step (lines 44/46). That keeps the template-injection risk because a crafted ref value containing quotes/newlines could break the generated shell script before any permission checks run. Consider removing ${{ inputs.ref }} from all run: blocks (e.g., pass it via env at the job level and reference $INPUT_REF/use printf '%s\n' when logging).

Copilot uses AI. Check for mistakes.

- name: Checkout gh-aw-actions (this repository)
uses: actions/checkout@v4
Expand Down
Loading