Skip to content

Adjust alert messages CWE-829/ArtifactPoisoning[Critical|Medium] #21640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knewbury01 merged 3 commits into from
Apr 8, 2026
Merged

Adjust alert messages CWE-829/ArtifactPoisoning[Critical|Medium] #21640

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e69e30a
Adjust alert messages CWE-829/ArtifactPoisoning[Critical|Medium]
knewbury01 Apr 2, 2026
4171465
Adjust alert messages actions CWE-829
knewbury01 Apr 2, 2026
7b7411f
Change alert location CWE-829/ArtifactPoisoning queries
knewbury01 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions actions/ql/src/Security/CWE-829/ArtifactPoisoningCritical.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ where
ArtifactPoisoningFlow::flowPath(source, sink) and
event = getRelevantEventInPrivilegedContext(sink.getNode())
select sink.getNode(), source, sink,
"Potential artifact poisoning in $@, which may be controlled by an external user ($@).", sink,
sink.getNode().toString(), event, event.getName()
"Potential artifact poisoning, which may be controlled by an external user ($@).", event,
event.getName()
3 changes: 1 addition & 2 deletions actions/ql/src/Security/CWE-829/ArtifactPoisoningMedium.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,4 @@ where
ArtifactPoisoningFlow::flowPath(source, sink) and
inNonPrivilegedContext(sink.getNode().asExpr())
select sink.getNode(), source, sink,
"Potential artifact poisoning in $@, which may be controlled by an external user.", sink,
sink.getNode().toString()
"Potential artifact poisoning, which may be controlled by an external user."
4 changes: 4 additions & 0 deletions actions/ql/src/change-notes/2026-04-02-alert-msg-poisoning.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: majorAnalysis
---
* Fixed alert messages in `actions/artifact-poisoning/critical` and `actions/artifact-poisoning/medium` as they previously included a redundant placeholder in the alert message that would on occasion contain a long block of yml that makes the alert difficult to understand.
Loading