Skip to content

fix: make Open in browser work from the first try. - #15342

Open
ValeraS wants to merge 1 commit into
gitbutlerapp:masterfrom
ValeraS:fix-open-in-browser
Open

fix: make Open in browser work from the first try.#15342
ValeraS wants to merge 1 commit into
gitbutlerapp:masterfrom
ValeraS:fix-open-in-browser

Conversation

@ValeraS

@ValeraS ValeraS commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

🧢 Changes

Disable "Open in browser" menu item until branchUrl is evaluated.

☕️ Reasoning

branchUrl is Svelte's $direved value, that is lazy and not (re-)evaluated until it is actually read. branchUrl is only read inside the menu item’s click handler. On the first click, reading it initialises compareBranchUrlQuery, which starts the async forgeCompareBranchUrl request—but its response is still undefined and onClick handler does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant