Skip to content

Tell the installer API whether this is a fresh install or an upgrade #15259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schacon wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −1
Open

Tell the installer API whether this is a fresh install or an upgrade #15259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,27 @@ main() {
INSTALLER_BIN=$(mktemp "${TMPDIR:-/tmp}/gitbutler-installer-bin.XXXXXX")
trap 'rm -f "$INSTALLER_JSON" "$INSTALLER_BIN"' EXIT INT TERM

# Detect an existing install, so a fresh install can be told apart from an
# upgrade. The installer itself discovers this, but only after downloading --
# by then the API has already answered, so the server can never distinguish
# the two. Checking here, before the request, is what makes it countable.
#
# Only a version number is sent: never a path, hostname, or anything about
# the machine. The value is parsed down to digits and dots, so whatever the
# local binary prints cannot inject anything into the URL.
EXISTING_VERSION=none
if command -v but >/dev/null 2>&1; then
# Anchored at the start: a leading `.*` would match greedily and leave
# only the final digit behind.
EXISTING_VERSION=$(but --version 2>/dev/null | head -1 | sed -n 's/^[^0-9]*\([0-9][0-9.]*\).*/\1/p')
# Installed, but the version could not be parsed.
[ -n "$EXISTING_VERSION" ] || EXISTING_VERSION=unknown
# Bound the length; printf is a shell builtin so this adds no dependency.
EXISTING_VERSION=$(printf '%.32s' "$EXISTING_VERSION")
fi

# Fetch installer metadata and validate effective URL
INSTALLER_API_URL="https://app.gitbutler.com/installers/info/$INSTALLER_OS/$INSTALLER_ARCH"
INSTALLER_API_URL="https://app.gitbutler.com/installers/info/$INSTALLER_OS/$INSTALLER_ARCH?from=$EXISTING_VERSION"
echo "Fetching installer information..."

EFFECTIVE_URL=$(curl --fail --silent --show-error --location --max-redirs 5 --max-time 300 \
Expand Down
Loading