Repository navigation
fix: serve local files with an empty mount prefix - #89
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Serve("", LocalFile(dir, false))currently skips existing files and falls through to the next handler.Existsrejects the request because trimming an empty prefix leaves the path length unchanged.Check whether the prefix matches before trimming it. Empty mounts now serve local files and index pages.
The tests cover GET, HEAD, directory listing policy, missing files and paths outside a mount.
They also cover the existing
/and/assetsmounts. Nine empty-prefix cases fail against unchanged master.The full suite passes with race detection on Go 1.26.0 and Go 1.27.1.
I ran
go test -v -race -covermode=atomic -coverprofile=coverage.out ./...and the configuredmake install-tools lint.The CI benchmark command, builds and vet also pass.