Repository navigation
fix: encode events that have no data - #64
Open
persicaTao wants to merge 1 commit into
Open
persicaTao wants to merge 1 commit into
persicaTao wants to merge 1 commit into
Conversation
A heartbeat event with a nil Data field panicked in reflect.Value.Kind. Write an empty data field instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A heartbeat such as
Event{Event: "ping"}leavesDatanil.kindOfDatacalledreflect.ValueOf(nil).Kind(), which panics. A nil pointer did the same onElem().Kind().Nil data now writes an empty
data:field and returns. String, map, and struct encoding is unchanged.Test plan
go test ./...TestEncodeNilDatacovers a nilDatafield and a nil pointer.