Find parent TabContainer in a more robust manner (for 4.7.2 compatibility)

[lfod1997]

Contribution

Fixes #44 .

Breaks nothing.

Tested Under

v4.7.2.stable.official [ed1daf0bf]

Details

Cause of Issue

In 4.7 the dragged TabBar is wrapped in HBoxContainer:

Drop data points to "@​TabBar@​4"; in the original impl:

if from_node is TabBar:
	from_node = from_node.get_parent()

from_node becomes "@​HBoxContainer@​2", which is still not the TabContainer we want, breaking a later call:

var moved_tab = from_node.get_tab_control(tab_index)

("Invalid call. Nonexistent function 'get_tab_control' in base 'HBoxContainer'.")

Solution

I suggest finding its first TabContainer ancestor in a loop:

while from_node is not TabContainer:
	from_node = from_node.get_parent()

It:

1. Fixes our problem
2. Does not break the "if not me, must be my immediate parent" semantics in earlier Godot versions
3. Somewhat future-proof