Skip to content

Fixed compatibility issues when dragging the TabBar in Godot 4.6. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gilzoide merged 1 commit into from
Feb 22, 2026
Merged

Fixed compatibility issues when dragging the TabBar in Godot 4.6. #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions addons/dockable_container/dockable_container.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,13 +237,20 @@ func get_tab_count() -> int:


func _can_handle_drag_data(data) -> bool:
if data is Dictionary and data.get("type") in ["tab_container_tab", "tabc_element"]:
var tabc := get_node_or_null(data.get("from_path"))
return (
tabc
and tabc.has_method("get_tabs_rearrange_group")
and tabc.get_tabs_rearrange_group() == rearrange_group
)
if not data is Dictionary:
return false
var type = data.get("type", "")
var tab_type = data.get("tab_type", "")
var is_valid_type = (
type in ["tab", "tab_container_tab", "tabc_element"]
or tab_type in ["tab_container_tab", "tabc_element"]
)
if is_valid_type:
var from_path = data.get("from_path")
if from_path:
var source_node = get_node_or_null(from_path)
if source_node and source_node.has_method("get_tabs_rearrange_group"):
return source_node.get_tabs_rearrange_group() == rearrange_group
return false


Expand Down