-
Notifications
You must be signed in to change notification settings - Fork 2.6k
macos: add proxy icon hover mode and disabled state #12166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -369,7 +369,7 @@ extension Ghostty { | |
| } | ||
|
|
||
| var macosTitlebarProxyIcon: MacOSTitlebarProxyIcon { | ||
| let defaultValue = MacOSTitlebarProxyIcon.visible | ||
| let defaultValue = MacOSTitlebarProxyIcon.hidden | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should not change the default to avoid surprising people that are used to (and perhaps prefer) the current behavior. |
||
| guard let config = self.config else { return defaultValue } | ||
| var v: UnsafePointer<Int8>? | ||
| let key = "macos-titlebar-proxy-icon" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3247,17 +3247,14 @@ keybind: Keybinds = .{}, | |
| /// | ||
| /// Valid values are: | ||
| /// | ||
| /// * `visible` - Show the proxy icon. | ||
| /// * `hidden` - Hide the proxy icon. | ||
| /// | ||
| /// The default value is `visible`. | ||
| /// Proxy icon visibility mode for the titlebar. Valid values: | ||
| /// - `visible` - always show the proxy icon | ||
| /// - `hidden` - show proxy icon on hover (default, modern macOS behavior) | ||
| /// - `disabled` - never show the proxy icon (drag-drop and context menu also disabled) | ||
| /// | ||
| /// This setting can be changed at runtime and will affect all currently | ||
| /// open windows but only after their working directory changes again. | ||
| /// Therefore, to make this work after changing the setting, you must | ||
| /// usually `cd` to a different directory, open a different file in an | ||
| /// editor, etc. | ||
| @"macos-titlebar-proxy-icon": MacTitlebarProxyIcon = .visible, | ||
| /// open windows immediately. | ||
| @"macos-titlebar-proxy-icon": MacTitlebarProxyIcon = .hidden, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should not change the default to avoid surprising people that are used to (and perhaps prefer) the current behavior. |
||
|
|
||
| /// Controls the windowing behavior when dropping a file or folder | ||
| /// onto the Ghostty icon in the macOS dock. | ||
|
|
@@ -8955,6 +8952,7 @@ pub const MacTitlebarStyle = enum { | |
| pub const MacTitlebarProxyIcon = enum { | ||
| visible, | ||
| hidden, | ||
| disabled, | ||
| }; | ||
|
|
||
| /// See macos-hidden | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not change the default to avoid surprising people that are used to (and perhaps prefer) the current behavior.