Skip to content

feat: resource fallback #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seia-soto wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: resource fallback #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bun.lockb
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"@adguard/scriptlets": "^1.12.1",
"@adguard/tsurlfilter": "2.2.23",
"@eyeo/webext-ad-filtering-solution": "1.5.0",
"@remusao/small": "^2.1.0",
"yaml": "^2.7.0"
},
"devDependencies": {
Expand Down
15 changes: 14 additions & 1 deletion src/converters/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { getResourceForMime } from '@remusao/small';
import resourceMapping from '../mappings.json';

export const DEFAULT_PARAM_MAPPING = {
Expand All @@ -6,14 +7,26 @@ export const DEFAULT_PARAM_MAPPING = {
frame: 'subdocument',
};

/**
* Get fallback resource for requested name
* @param {string} name The resource name
*/
function getFallbackResource(name) {
const index = name.lastIndexOf('.');
if (index === -1) {
return getResourceForMime(name);
}
return getResourceForMime(name.slice(index));
}

/**
* Translates resource name
* @param {string} name The source resource name
* @param {'ubo' | 'adg'} dialect The destination dialect
* @returns Translated dialect or passes given name in case of not found
*/
function convertName(name, dialect) {
return resourceMapping[name]?.[dialect] ?? name;
return resourceMapping[name]?.[dialect] || getFallbackResource(name);
}

/**
Expand Down