feat(queries): print JSON message for 4xx/422 responses before HTTPError - #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When GitHub returns a 4xx response (such as 422 Validation Failed), the response includes a JSON body with a
messagefield. This PR adds a helper function to extract and print themessagefield before raising the status exception in_make_pr_request_with_retry.Changes
_print_4xx_error_messagetoreviewtally/queries/get_prs.pyto check for 4xx status codes, parse the JSON body, and print themessagefield._make_pr_request_with_retryright before callingraise_for_status.tests/test_get_prs.pyto assert correct printing for 422 responses and handle cases without messages or with invalid JSON.Verification
poetry run pytest -m "not integration"passed successfully.poetry run ruff check .andpoetry run ruff format .passed successfully.