Upload size limits (GSI-2298)#166
Conversation
|
|
||
| # Presigned URL rate limiting (optional) | ||
| max_part_urls_per_minute: int = 0 # 0 = disabled; token bucket refill rate | ||
| part_url_burst_size: int = 10 # Token bucket initial/max tokens |
There was a problem hiding this comment.
Would go for a slightly different name here to make clear what that means in isolation, i.e. how many presigned URLs per timespan.
Might also be worth to expose the time span separately instead of hardcoding it to a minute to better fine tune spacing of requests.
One minute might be a long enough time span to exhaust the token bucket at the very beginning and then wait for the rest.
Would be better if we can test and fine tune with different bucket sizes/time spans to condition that behavior.
There was a problem hiding this comment.
I've adjusted it and think it fits better now.
There was a problem hiding this comment.
Still not fully sold on that.
What about instead separating the time span an refill_rate per time span, so they are independently configurable and can be adapted to changing circumstances?
There was a problem hiding this comment.
Per our offline discussion, we're using a refill interval param
3 participants
No description provided.