Replace __HIP_PLATFORM_HCC__ with __HIP_PLATFORM_AMD__#211
Merged
Conversation
stubbiali
force-pushed
the
update-hip-macro
branch
from
a1a9e66 to
8f107f6
Compare
Contributor
Author
|
@msimberg This is another short PR where your feedback would be appreciated. Thanks! |
msimberg
approved these changes
May 28, 2026
Collaborator
msimberg
left a comment
msimberg
left a comment
There was a problem hiding this comment.
Nice, thanks for catching this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along with GridTools/gridtools#1830 and ghex-org/hwmalloc#52, this PR is needed to build the Python bindings on LUMI using the latest software stack (LUMI/25.03), .