Increase recursion limits to please -Znext-solver#9609
Open
nazar-pc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #9608
Description
I think this is a lack of optimization in the next solver, so this will likely become unnecessary at some point in the future, but as it stands today, with default recursion limit it is not possible to compile
wgpu-coreandwgpucrates with-Znext-solver.Since the fix is simple and otherwise harmless, I hope it is acceptable and can be backported into stable version.
Testing
Applied this to 29.0.3 locally and ensured things compile with
RUSTFLAGS="-Znext-solver=globally".Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.