Skip to content

Increase recursion limits to please -Znext-solver#9609

Open
nazar-pc wants to merge 1 commit into
gfx-rs:trunkfrom
nazar-pc:please-next-solver
Open

Increase recursion limits to please -Znext-solver#9609
nazar-pc wants to merge 1 commit into
gfx-rs:trunkfrom
nazar-pc:please-next-solver

Conversation

@nazar-pc
Copy link
Copy Markdown

Connections

Fixes #9608

Description

I think this is a lack of optimization in the next solver, so this will likely become unnecessary at some point in the future, but as it stands today, with default recursion limit it is not possible to compile wgpu-core and wgpu crates with -Znext-solver.

Since the fix is simple and otherwise harmless, I hope it is acceptable and can be backported into stable version.

Testing

Applied this to 29.0.3 locally and ensured things compile with RUSTFLAGS="-Znext-solver=globally".

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not compile with -Znext-solver=globally: overflow evaluating the requirement

1 participant