Mask stencil clear value and reference value with 255#9607
Merged
andyleiserson merged 3 commits intoJun 2, 2026
Conversation
e7ec315 to
5a62e47
Compare
5a62e47 to
523a1cf
Compare
andyleiserson
requested changes
Jun 1, 2026
Contributor
andyleiserson
left a comment
There was a problem hiding this comment.
I don't actually see truncation of the reference value in the spec, but that is what the CTS wants, and seems right to me. Filed gpuweb/gpuweb#6273 for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fix
webgpu:api,operation,render_pass,clear_value:stencil_clear_value:*on metal.Found this issue in #9568.
Description
See gpuweb/gpuweb#2921 and https://issues.chromium.org/issues/42240605, we need to take the LSBs of stencil value. Currently only 8-bit stencil formats are supported so
value & 255.Testing
Squash or Rebase?
Squash
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.